Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

feat(React): Add a Home Component #20

Merged
merged 1 commit into from
Jan 16, 2018
Merged

feat(React): Add a Home Component #20

merged 1 commit into from
Jan 16, 2018

Conversation

rhy0u
Copy link
Contributor

@rhy0u rhy0u commented Jan 16, 2018

No description provided.

@rhy0u
Copy link
Contributor Author

rhy0u commented Jan 16, 2018

User Story #1
Feature #7

@jsfez jsfez self-assigned this Jan 16, 2018
@rhy0u rhy0u requested a review from jsfez January 16, 2018 11:00
@jsfez jsfez removed their assignment Jan 16, 2018
pages/index.js Outdated
import React from 'react'
import Home from './Home'

const firstComp = () => <Home />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop ! Remane this variable

@jsfez jsfez merged commit def64ba into master Jan 16, 2018
@jsfez jsfez deleted the home-component branch January 16, 2018 11:21
@gregberge
Copy link
Member

Un petit test sur le Home aurait été un plus. Il est simple pour le moment mais il va forcément se complexifier. Au moins un snapshot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants