Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: GitHub workflow #16

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

carlomion
Copy link

Fixes #15.
Add GitHub workflow to:

  • build the docker image, caching the intermediate layers to speed up the CI pipeline
  • test that all the containers start up successfully
    • setup the DB with monaco OSM data
    • test that /health endpoint returns succesfully

Copy link
Member

@dsperling dsperling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding workflows in welcome, but a few requests:

  1. This project is focused on small Docker images, but the build-time optimizations make the n7m app image larger. Can we back these changes out without impacting the workflow?
  2. We are splitting n7m-app into two images - n7m-api and n7m-feed. These changes will be merged soon and the workflow will need to be changed. See feature/api branch.
  3. Could you recommend text for the README for developers to get this setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: GitHub Action for automated testing
2 participants