Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use worktree for docker #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use worktree for docker #23

wants to merge 2 commits into from

Conversation

a-miyadera
Copy link
Contributor

@a-miyadera a-miyadera commented Aug 4, 2023

  • Use the current worktree for docker image
  • Use layered workspace (to reduce build time after the second time)

git clone https://github.com/smilerobotics/haruna.git && \
vcs import < haruna/.rosinstall && \
rosdep install --from-paths . -y && \
catkin init
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we care about the image size, we should remove apt cache by 'rm -rf /var/lib/apt/lists/*', because L16 do apt install.
(But it increases the build time because we will do ti again in L31.

Do you have good idea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(But it increases the build time because we will do ti again in L31.

That's exactly why I didn't do so.

Do you have good idea?

If we install all the needed packages from haruna in apt-get install beginning from L6,
we may possibly not need rosdep install in L31.
(But we have to update the apt-get install lines, every time the haruna dependencies are changed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants