Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v10.3.3 #274

Merged
merged 3 commits into from
Dec 20, 2024
Merged

chore: release v10.3.3 #274

merged 3 commits into from
Dec 20, 2024

Conversation

tobitech
Copy link
Contributor

Prepare SDK for release - v10.3.3

@tobitech tobitech self-assigned this Dec 20, 2024
@tobitech tobitech requested a review from a team as a code owner December 20, 2024 18:03
@prfectionist
Copy link

prfectionist bot commented Dec 20, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Breaking Change
The removal of the pre-compiled SelfieQualityModel.mlmodelc file may impact selfie quality check functionality. Need to verify if there is an alternative implementation or if this is intended to be removed without replacement.

@prfectionist
Copy link

prfectionist bot commented Dec 20, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link

Warnings
⚠️ The source files were changed, but the tests remain unmodified. Consider updating or adding to the tests to match the source changes.
⚠️

Sources/SmileID/Classes/SmileID.swift#L159 - Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)

⚠️

Sources/SmileID/Classes/SmileID.swift#L186 - TODOs should be resolved (- Fix when Michael changes thi...). (todo)

Generated by 🚫 Danger Swift against ac4a1fd

@tobitech tobitech merged commit 4391d16 into main Dec 20, 2024
4 checks passed
@tobitech tobitech deleted the release/10.3.3 branch December 20, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants