Smart Selfie Capture Flow

[jumaallan]

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

[prfectionist]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Hardcoded Value The progress animation uses a hardcoded target value of 0.5F which may not reflect actual progress. Consider making this dynamic based on actual capture progress. Code Removal Significant UI components were removed (DirectiveVisual, AnimatedImageFromSelfieHint) without clear replacement for visual feedback during selfie capture process Code Duplication Commented out code block is kept alongside new implementation. Should be removed if no longer needed.

[prfectionist]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Enhancement	Add duration parameter to animation specification for smoother visual transitions The animation duration for progress indicator is missing. Add a duration parameter to the tween animation spec for smoother animation. lib/src/main/java/com/smileidentity/compose/selfie/v2/SelfieCaptureScreenV2.kt [279] -animationSpec = tween(easing = LinearEasing), +animationSpec = tween(durationMillis = 1000, easing = LinearEasing), Suggestion importance[1-10]: 6 Why: Adding an explicit animation duration improves the user experience by ensuring consistent and smooth animations. This is a functional improvement that affects the UI behavior.	6
Maintainability	Split chained modifiers into multiple lines for better code readability The chained modifiers should be on separate lines for better readability and maintainability. Split the chained modifiers into multiple lines. lib/src/main/java/com/smileidentity/compose/selfie/FaceShapedProgressIndicator.kt [47] -Canvas(modifier = modifier.progressSemantics(progress).fillMaxSize()) { +Canvas( + modifier = modifier + .progressSemantics(progress) + .fillMaxSize() +) { Suggestion importance[1-10]: 4 Why: The suggestion improves code readability by breaking down chained modifiers into separate lines, making the code more maintainable and easier to modify. However, it's a minor stylistic improvement.	4
	Organize constructor parameters in a more logical order with core parameters first The SelfieCaptureParams constructor call has many parameters that could be more readable using named arguments. lib/src/main/java/com/smileidentity/compose/SmileIDExt.kt [85-95] val commonParams = SelfieCaptureParams( userId = userId, jobId = jobId, + isEnroll = true, allowNewEnroll = allowNewEnroll, allowAgentMode = allowAgentMode, showAttribution = showAttribution, showInstructions = showInstructions, extraPartnerParams = extraPartnerParams, - isEnroll = true, skipApiSubmission = skipApiSubmission, ) Suggestion importance[1-10]: 3 Why: While the suggestion improves code organization by grouping core parameters first, the existing code is already using named arguments and is quite readable. The improvement is minimal and purely cosmetic.	3

[JNdhlovu]

Needed still?

[JNdhlovu]

Ditto

[JNdhlovu]

ios sitll has this within the same product but this as an option

[JNdhlovu]

new destination maybe to not break this?