Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version to 10.3.7 #496

Closed
wants to merge 2 commits into from
Closed

bump version to 10.3.7 #496

wants to merge 2 commits into from

Conversation

JNdhlovu
Copy link
Contributor

prep 10.3.7

@JNdhlovu JNdhlovu requested a review from a team as a code owner November 19, 2024 07:57
@prfectionist
Copy link

prfectionist bot commented Nov 19, 2024

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Conflict
The new version file contains both 10.3.7-SNAPSHOT and 10.3.6-SNAPSHOT. This appears to be a mistake as version files typically should only contain one version.

@prfectionist
Copy link

prfectionist bot commented Nov 19, 2024

PR Code Suggestions ✨

No code suggestions found for the PR.

@jumaallan
Copy link
Member

@JNdhlovu this was already bumped up

https://github.com/smileidentity/android/blob/main/lib/VERSION

@JNdhlovu
Copy link
Contributor Author

@JNdhlovu this was already bumped up

https://github.com/smileidentity/android/blob/main/lib/VERSION

lol and I'm the one who did it

@JNdhlovu JNdhlovu closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JNdhlovu JNdhlovu

Labels
Review effort [1-5]: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JNdhlovu @jumaallan