Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprint #400

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Add fingerprint #400

merged 8 commits into from
Jul 3, 2024

Conversation

vanshg
Copy link
Collaborator

@vanshg vanshg commented Jul 3, 2024

Summary

Adds fingerprint as a default metadata item using fingerprintjs-android.

Known Issues

We can not ship this in an SDK release until fingerprintjs/fingerprintjs-android#76 is resolved

@vanshg vanshg requested a review from a team as a code owner July 3, 2024 03:29
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this get sent to the backend?

@vanshg vanshg force-pushed the metadata-fingerprint branch from 6e9820a to b73a301 Compare July 3, 2024 03:33
@vanshg
Copy link
Collaborator Author

vanshg commented Jul 3, 2024

fingerprint is already a valid metadata key, and I'm adding it here to the set of default keys, so we'd include it anywhere we use that. Currently only SmartSelfie products, but #398 extends it to Prep Upload

@jumaallan
Copy link
Member

You need to fix the tests

Base automatically changed from metadata-document-image-origin to metadata July 3, 2024 18:06
@vanshg vanshg merged commit cdd855d into metadata Jul 3, 2024
3 checks passed
@vanshg vanshg deleted the metadata-fingerprint branch July 3, 2024 18:33
@vanshg vanshg mentioned this pull request Jul 16, 2024
vanshg added a commit that referenced this pull request Jul 16, 2024
* Randomized face direction

* Add halfway captures

* add stability timer

* Add docs, cleanup

* Move to util; add constants

* Bump versions

* Add useStrictMode (#362)

* Add useStrictMode

* Fix test

* Bump versions

* Active liveness UI (#363)

* Add useStrictMode

* wip

* New UI prototype, less finicky

* add docs

* More UI updates

* Fix test

* Add active liveness forced failure and update design (#364)

* Add useStrictMode

* wip

* New UI prototype, less finicky

* add docs

* More UI updates

* Add metadata

* Fix test

* Add forced failure

* update timeout

* remove unused value

* add breadcrumbs

* increase num liveness images and add doc

* prevent rotation

* Add CameraFrameCornerBorder

* restructure + loading/success/error

* cleanup

* Update library version

* Add smile directive

* Use Lottie for directive animations (#366)

* Add Lottie face animation

* Fix need light animation

* Add Enrollment v2 (#367)

* Add Enrollment v2

* Fix test

* Impose upper bound on active liveness head angle (#368)

* Impose upper bound on active liveness head angle

* Update condition

* Add missing compatibility properties, agent mode, and attribution

* Move to constants

* Bump lottie

* Fix bad version

* Metadata

* Allow parameter tuning

* Active liveness parameter tuning. Update face quality model input crop

* Add header metadata back for now

* Fix contour out of bounds

https://smile-identity.sentry.io/issues/5453193521

* Make feedback more responsive during active liveness

* ignore certain faces. debug output

* Update CHANGELOG

* Fix viewfinder rect

* Lint

* Merge

* Reset capture progress on orientation change (#382)

* Reset capture progress on orientation change

* Lint

* Bump versions

* UI update and task confirmation (#385)

* Parameter updates, clipboard copy, larger UI

* Fail active liveness after timeout (#390)

* Use oval cutout

* Update parameters

* Remove parameter tuning and debug output

* Add useStrictMode to top level composable

* Use Strict Mode naming on main screen

* Update versions

* MetadataAdapter comment

* Add metadata to prepUpload

* Track document image origin (#398)

* Track document image origin

* Update test

* Update test

* Update test

* Add fingerprint (#400)

* Track document image origin

* Update test

* Add fingerprint

* Use default empty string instead of lateinit var

* Update test

* Track metrics using CompositionLocal (#402)

* Track metrics using CompositionLocal

* Clear DocumentCapture metadata on retry

* Clarify some metadata

* Update naming and format

* Update names

* Send metadata on DocV

* Fix enum value

* Update CHANGELOG

* Merge

* Fix colors

* Remove fingerprint JS

* Update settings.gradle.kts

* Prepare for 10.2.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants