Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import Buffer from buffer #471

Merged
merged 5 commits into from
Nov 8, 2024
Merged

import Buffer from buffer #471

merged 5 commits into from
Nov 8, 2024

Conversation

sakari
Copy link
Collaborator

@sakari sakari commented Nov 6, 2024 •
edited
Loading

Buffer is node specific api which causes trouble when trying to use oats-runtime in browser.

  • use feross/buffer which has separate entrypoints for node (using node Buffer) and browser (using a lookalike)
  • remove the typescript reference from make.d.ts that includes node types

canary release @7.5.1-alpha.11

@sakari sakari requested a review from lautis November 8, 2024 08:58
@sakari sakari merged commit f80f026 into master Nov 8, 2024
1 check passed
@sakari sakari deleted the import-buffer-from-buffer branch November 8, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lautis lautis lautis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakari @lautis