Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractReader Interface Tests #945

Merged
merged 8 commits into from
Dec 11, 2024
Merged

ContractReader Interface Tests #945

merged 8 commits into from
Dec 11, 2024

Conversation

EasterTheBunny
Copy link
Contributor

Create interface tests for basic ContractReader interface.

@EasterTheBunny EasterTheBunny requested review from a team as code owners November 26, 2024 14:30
@EasterTheBunny EasterTheBunny marked this pull request as draft November 26, 2024 14:30
@EasterTheBunny EasterTheBunny changed the title progress ContractReader Interface Tests Nov 26, 2024
@EasterTheBunny EasterTheBunny force-pushed the etb/contract-reader-integration-test branch from 5d1fb6a to 7d2e97a Compare November 26, 2024 14:33
@ilija42 ilija42 changed the title ContractReader Interface Tests [NONEVM-953] - ContractReader Interface Tests Nov 26, 2024
@ilija42 ilija42 changed the title [NONEVM-953] - ContractReader Interface Tests ContractReader Interface Tests Nov 26, 2024
@EasterTheBunny EasterTheBunny dismissed stale reviews from silaslenihan and aalu1418 via de65b9c December 11, 2024 17:14
@EasterTheBunny EasterTheBunny force-pushed the etb/contract-reader-integration-test branch from 45ffe68 to de65b9c Compare December 11, 2024 17:14
@EasterTheBunny EasterTheBunny force-pushed the etb/contract-reader-integration-test branch from de65b9c to 610393b Compare December 11, 2024 17:30
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit a9ea8fd into develop Dec 11, 2024
35 of 36 checks passed
@aalu1418 aalu1418 deleted the etb/contract-reader-integration-test branch December 11, 2024 17:51
silaslenihan pushed a commit that referenced this pull request Dec 11, 2024
@EasterTheBunny @silaslenihan
ContractReader Interface Tests (#945)
5c6ec08 
* simple interface tests implementation

* ContractWriter interface updates

* add relay interface tests to relay workflow

* move interface test to rust workflow and clean up Anchor.toml

* add comment for rpc client wrapper

* install solana CLI path fix

* remove cd contracts

* add env var to e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad approved these changes

@aalu1418 aalu1418 aalu1418 approved these changes

@ilija42 ilija42 ilija42 left review comments

@silaslenihan silaslenihan silaslenihan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EasterTheBunny @silaslenihan @aalu1418 @ilija42 @chainchad