Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handlers #403

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Refactor handlers #403

merged 3 commits into from
Sep 30, 2023

Conversation

smallwat3r
Copy link
Owner

Refactor how handlers handle requests.
Also ensure to use typing.TYPE_CHECKING flag.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (ab0a8e0) 97.56% compared to head (1e93ce9) 94.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   97.56%   94.17%   -3.39%     
==========================================
  Files          14       14              
  Lines         451      498      +47     
==========================================
+ Hits          440      469      +29     
- Misses         11       29      +18     
Files Coverage Δ
shhh/__init__.py 100.00% <100.00%> (ø)
shhh/api/schemas.py 98.18% <80.00%> (-1.82%) ⬇️
shhh/scheduler/tasks.py 95.00% <75.00%> (-5.00%) ⬇️
shhh/api/api.py 88.46% <75.00%> (-11.54%) ⬇️
shhh/config.py 80.43% <50.00%> (-5.28%) ⬇️
shhh/entrypoint.py 94.62% <66.66%> (-3.11%) ⬇️
shhh/liveness.py 92.18% <57.14%> (-4.48%) ⬇️
shhh/api/handlers.py 94.52% <93.65%> (-5.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallwat3r smallwat3r merged commit c458a69 into master Sep 30, 2023
5 of 7 checks passed
@smallwat3r smallwat3r deleted the refactor-handlers branch November 18, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant