Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new methods in nosql to enable querying for Certificates. #696

Closed
wants to merge 1 commit into from

Conversation

TheSecMaven
Copy link
Contributor

Description

This resolves #688 and enables users to perform a normal upgrade of smallstep, and the new schema will be migrated to. At which point users can begin to query for certificates the application has signed on a go forward basis. This is reliant on smallstep/nosql#15, and then updating the version of the dependency used in this project.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Sep 4, 2021
@dopey
Copy link
Contributor

dopey commented Sep 8, 2021

smallstep/nosql#15

This relies on changes to the nosql package (PR linked above). We will not merge those changes (reasons given in the PR), therefore this PR would need modification as well.

To recap, we are interested in a SQL implementation of the following interface: https://github.com/smallstep/certificates/blob/master/db/db.go#L45. The existing implementation in open source uses nosql, and is subsequently difficult to query against.

@dopey dopey closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Attributes of Certificates in x509_certs alongside the whole certificate
3 participants