Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-constant webhook error message linter issue #2067

Closed
wants to merge 1 commit into from
Closed

Fix non-constant webhook error message linter issue #2067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acme/order.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ func (o *Order) Finalize(ctx context.Context, db DB, csr *x509.CertificateReques
// Add subproblem for webhook errors, others can be added later.
var webhookErr *webhook.Error
if errors.As(err, &webhookErr) {
acmeError := NewDetailedError(ErrorUnauthorizedType, webhookErr.Error())
acmeError := NewDetailedError(ErrorUnauthorizedType, webhookErr.Error()) //nolint:govet // allow non-constant error messages
acmeError.AddSubproblems(Subproblem{
Type: fmt.Sprintf("urn:smallstep:webhook:error:%s", webhookErr.Code),
Detail: webhookErr.Message,
Expand Down