Fix OpenTelemetryProducer to work with the security manager. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bstansberry I could use your insight here too, while this does fix our current issues, I am not sure whether we require this in SR OpenTelemetry or whether we can fix this in WildFly, initializing Otel early enough - is that possible @jasondlee? cc @kabir |
jasondlee
requested changes
Dec 3, 2024
...on/cdi/src/main/java/io/smallrye/opentelemetry/implementation/cdi/OpenTelemetryProducer.java
Show resolved
Hide resolved
rhusar
force-pushed
the
security-manager
branch
2 times, most recently
from
2962e6d
to
34552ff
Compare
rhusar
force-pushed
the
security-manager
branch
from
5ddfd8f
to
5f0118a
Compare
jasondlee
approved these changes
Dec 3, 2024
|
@rhusar I think this is ok. Dealing with SM issues at the finest granularity possible is best IMHO. I don't know enough about what it would take to do it in WF code but I expect it would be more coarse grained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream issue in WF which still supports security manager:
https://issues.redhat.com/browse/WFLY-20043