Add TLS support #402
Open
Add TLS support #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondlee
force-pushed
the
SROTEL-396
branch
3 times, most recently
from
fe63f5e
to
0829a4f
Compare
Add configuration constants for property names Move constants to a holder class Port HttpClientOptionsConsumer from Quarkus Modify HCOP to use ConfigProperties General code cleanup
jasondlee
force-pushed
the
SROTEL-396
branch
from
0829a4f
to
5159b9c
Compare
brunobat
requested changes
Nov 28, 2024
There was a problem hiding this comment.
I'm just trying to keep the senders aligned with what we have in https://github.com/quarkusio/quarkus/blob/e559cbdf93faac811d028f5af6acd5ad44b2f412/extensions/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/sender/VertxGrpcSender.java#L65
| private final String grpcEndpointPath; | ||
|
|
||
| private final GrpcClient client; | ||
|
|
||
| public VertxGrpcSender( | ||
| String signalType, |
There was a problem hiding this comment.
Why do you need a signal type? The marshaller will handle that.
There was a problem hiding this comment.
It's used in the property lookup to get signal-specific configurations. See here, for example: https://github.com/smallrye/smallrye-opentelemetry/pull/402/files#diff-a90e43f59d93847ebb3a932a020d18b407e60ab8325d6839be09ec3fcc30be19R73-R79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration constants for property names
Move constants to a holder class
Port HttpClientOptionsConsumer from Quarkus
Modify HCOP to use ConfigProperties
General code cleanup
Fixes #396