[Enhancement] Tries to inject Vertx instance from CDI using a qualifier

[gaol]

Fixes #380

This PR tries to add a new config otel.exporter.vertx.cdi.identifier to tries to inject the Vertx instance from the CDI with the qualifier, and it falls back to current way of Vertx.vertx() if there is no such configuration to keep compatible.

[jasondlee]

@gaol, This looks good. Once the formatting checks have been satisfied, I can merge this.

[gaol]

@jasondlee from the discussion in smallrye/smallrye-reactive-messaging#2772, do you see problem if using Identifier instead of Named qualifier in smallrye-opentelemetry ? which would mean that there will be a dependency of io.smallrye.common:smallrye-common-annotation added to the exports artifact in this project, and a dependency of io.smallrye.common.annotation to the jboss module: io.smallrye.opentelemetry in WildFly.

[gaol]

@jasondlee I updated the PR to use @io.smallrye.common.annotation.Identifier from smallrye-common-annotation, would you please check again ? thank you :)

[gaol]

Hello @jasondlee , I updated according to your feedback to log a warning message and return a new Vertx instance in case it cannot resolve from CDI. Would you please review again ? thank

[Ladicek]

Just interjected a few comments, feel free to ignore or do whatever you wish with them :-)

[jasondlee]

I left one last comment.

[gaol]

@jasondlee I think exposing one instance of a bean using a qualifier can also leave it to the lookup side to decide if it wants the bean or not. Trying to lookup the bean without qualifier will hand over the decision out :) I remembered in the zulip discussion that we want the lookup side be able to opt in, at least in the start time of integrating the vertx subsystem.

Please feel free to correct me if I am wrong. :)

[jasondlee]

@jasondlee I think exposing one instance of a bean using a qualifier can also leave it to the lookup side to decide if it wants the bean or not. Trying to lookup the bean without qualifier will hand over the decision out :) I remembered in the zulip discussion that we want the lookup side be able to opt in, at least in the start time of integrating the vertx subsystem.

Please feel free to correct me if I am wrong. :)

I just reread that and you're correct. Given that, I think this looks great. I'll get it merged. Thanks!

[jasondlee]

HI, @gaol. One more thing: commits to this repo have to be signed. Once you've signed this commit, I'll merge it.

[gaol]

@jasondlee Updated to signed commit :)

[jasondlee]

@jasondlee Updated to signed commit :)

It's still complaining that the commit isn't signed. Have you done this? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[gaol]

@jasondlee sorry, I got the wrong idea, I understood that as Signed-off-by , will update again.

[gaol]

@jasondlee finally, I got the the signed commit :)

[jasondlee]

No worries. Got it. Thanks, @gaol , @Ladicek !