Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SecurityManager #1194

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove SecurityManager #1194

wants to merge 1 commit into from

Conversation

radcortez
Copy link
Member

No description provided.

@radcortez radcortez requested a review from dmlloyd July 4, 2024 19:28
@dmlloyd
Copy link
Contributor

dmlloyd commented Jul 5, 2024

Do we know that all downstream consumers (specifically WildFly) are OK with not having security manager support?

darranl
darranl suggested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WildFly is going to need to retain security manager support as long as we are supporting Jakarta EE 10 - this also looks to be submitted to a branch which is producing micro releases, should a removal like this trigger a larger version bump?

@radcortez
Copy link
Member Author

WildFly is going to need to retain security manager support as long as we are supporting Jakarta EE 10 - this also looks to be submitted to a branch which is producing micro releases, should a removal like this trigger a larger version bump?

We only set the release version on the actual release. Right now, it is just the version generated by Maven. We may consider moving to something like 999-SNAPSHOT for development like Quarkus.

Ok, let's keep the SecurityManager for a little longer.

@radcortez radcortez marked this pull request as draft July 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl requested changes

@dmlloyd dmlloyd Awaiting requested review from dmlloyd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radcortez @dmlloyd @darranl