Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for setting Tolerations and Affinity + setting PVC classes for all PVCs for the Nextcloud app + update deps #304

Merged
merged 4 commits into from
Aug 18, 2024

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Aug 18, 2024

New nextcloud app features

Adds support for setting individual PVC storage classes

Now you can use different storage classes for each PVC we support configuring for the nextcloud app. This includes the SeaweedFS PVCs - for PostgreSQL backups, as well the files and config PVCs for the nextcloud app itself. This is done via apps.nextcloud.argo.secret_keys and is completely optional. If you don't set these values, we'll default to the apps_global_config.pvc_storage_class value.

Example yaml values:

apps:
  nextcloud:
    argo:
      secret_keys:
        files_storage_class: "local-path"
        config_storage_class: "local-path"
        s3_pvc_storage_class: "local-path"

Adds support for setting Tolerations and Affinity

You can now set your apps.nextcloud.argo.path to nextcloud/app_of_apps_with_tolerations/ to allow for setting tolerations for node taints, as well as affinity to make the pods stick to one node.

Adds the following new optional yaml values:

apps:
  nextcloud:
    argo:
      path: nextcloud/app_of_apps_with_tolerations/
      secret_keys:
        # you can delete these if you're not using tolerations/affinity
        toleration_key: ""
        toleration_operator: ""
        toleration_value: ""
        toleration_effect: ""
        # these are for node affinity, delete if not in use
        affinity_key: ""
        affinity_value: ""
        hostname: ""

Also updates some dependencies to close out a number of PRs in this repo

  • bcrypt
  • pyjwt
  • textual
  • deptry
  • pytest-textual-snapshot

Plus anything caught with a poetry update.

Additional Info

Compliments small-hack/argocd-apps@a49d61e and small-hack/argocd-apps@4294779

This should also include a patch to use PodConfigRef for k8up Restores.

…xtcloud pvc instead of always using the global storage class
@jessebot jessebot requested a review from cloudymax August 18, 2024 13:52
@jessebot jessebot self-assigned this Aug 18, 2024
@jessebot jessebot added the ✨ enhancement New feature request label Aug 18, 2024
Copy link
Collaborator

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@jessebot
Copy link
Collaborator Author

Testing this on our local infra now 🙏

@jessebot jessebot merged commit 453c109 into main Aug 18, 2024
4 checks passed
@jessebot jessebot deleted the dep-updates-aug-2024 branch August 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants