Add sleeps to node ip search and zitadel api health queries; also improve env var tooltip for sensitive init values #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to reduce log output and try to avoid raise conditions
jessebot
added a commit
that referenced
this pull request
May 15, 2024
…rove env var tooltip for sensitive init values (#174) * adding sleeps for zitadel api query as well as k3s internal ip query to reduce log output and try to avoid raise conditions * improve sensitive value tooltip * catch error if there's no res at all when checking zitadel api health
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the sleeps for the node ip search, when joining a new node and searching for the control plane node's internal IP, it can genearte dozens of log entries clogging up your screen. This waits just 2 seconds between tries to free up some more of your screen.
Without the sleeps and catching of SSLError for zitadel api health queries, it can sometimes time out before the ssl cert is ready (like if you're using the DNS01 challenge type for the ACME Issuer type), which will cause smol-k8s-lab to just crash in the most depressing way, because then you have to delete the zitadel app of apps, clean up the namespace and try smol-k8s-lab again, which is pain because you have to backup the tls cert if it's letsencrypt-prod or you'll get locked out of ACME's servers for like a month if you're doing a lot of back to back testing D:
the tooltip improvement was just to avoid the user needing to look up the env var in the docs :)