Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #132: don't overwrite k3s custom config #133

Merged
merged 3 commits into from
Jan 10, 2024
Merged

fix #132: don't overwrite k3s custom config #133

merged 3 commits into from
Jan 10, 2024

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Jan 10, 2024 •
edited
Loading

@jessebot jessebot added 🐛 bug Something isn't working k3s labels Jan 10, 2024
@jessebot jessebot requested a review from cloudymax January 10, 2024 19:17
@jessebot jessebot self-assigned this Jan 10, 2024
@jessebot jessebot mentioned this pull request Jan 10, 2024
Closed
cloudymax
cloudymax approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jessebot jessebot merged commit ffe9840 into main Jan 10, 2024
2 checks passed
@jessebot jessebot deleted the fix/issue-132-overwrite-k3s-config branch January 10, 2024 19:32
jessebot added a commit that referenced this pull request May 15, 2024
@jessebot
fix #132: don't overwrite k3s custom config (#133)
2179382 
* fix #132: don't overwrite k3s custom config

* change README ordering of upgrade instructions and make sure tests ignore docs/ci changes

* update pypi description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudymax cloudymax cloudymax approved these changes

Assignees

@jessebot jessebot

Labels
🐛 bug Something isn't working k3s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Selecting "New Cluster" causes distro section of configfile to be overwritten
2 participants
@jessebot @cloudymax