Feature: Add support for mysql #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was written as "verboselt-cred-mech" because there was no newline, so it has been corrected.
|
Sorry for such a delay. let me take a look :) |
jessebot
approved these changes
Mar 27, 2024
|
This looks great, but we need to bump the helm chart version :) I can merge this for now, and then I'll manually bump the helm chart version. It may also make sense to make the initdb configmap only deploy if mysql is enabled. To unblock though, I'll merge this now. Thanks for your contribution. Please note: I am moving this to my github org: small-hack, but it is also an AGPL focused org of just a few people and will be better maintained with renovate bot there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi , I've created a pull request that addresses #15 in this project
I have added support for connecting to bundled subchart's MySQL or an external MySQL database.
Could someone please review it and provide feedback?