Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extraConfig): Dont fail with multiple lines #126

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

4censord
Copy link
Contributor

This fixes #125

@jessebot
Copy link
Collaborator

Thanks for the fix! We need to bump the helm chart version here. I can do that for you, but in the future, please do that so we can merge a bit faster.

@jessebot jessebot merged commit a9dbba6 into small-hack:main Oct 20, 2024
5 of 6 checks passed
@jessebot
Copy link
Collaborator

Just wanted to follow up with an apology for taking so long to tend to this chart. I was on a bit of a mental health vacation, but thank you again for your fix <3

@4censord
Copy link
Contributor Author

hey, dont worry about it. Health is always more important!.

And yeah, i totally forgot the version bump, at work ci does that for me 😁

@4censord 4censord deleted the fix-multiline-extraconfig branch October 20, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having more than one line of extraConfig fails to template.
2 participants