update readme

small-hack · Dec 20, 2024 · 49eb0f9 · 49eb0f9
1 parent e128173
commit 49eb0f9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 18 deletions.
diff --git a/demo/argo-workflows/README.md b/demo/argo-workflows/README.md
@@ -2,9 +2,13 @@
 
 Argo Workflows is an open source container-native workflow engine for orchestrating parallel jobs on Kubernetes.
 
-Argo Workflows lets you define a YAML configuration with multiple steps, representing the steps in your CI/CD pipeline. Each of these steps runs in a separate container within your Kubernetes cluster. 
+Argo Workflows lets you define a YAML configuration with multiple steps, representing the steps in your CI/CD pipeline. Each of these steps runs in a separate container within your Kubernetes cluster.
 
 Argo uses a CRD called Workflows, which provides a generateName. This name becomes the prefix of all the pods the Workflow runs. As part of the Workflow, you can also define storage volumes, which will be accessible by the templates for your workflow steps.
 
 
 > Depends on Argo Server already existing, so make sure you install ArgoCD first.
+
+TODO:
+- replace secret manifests with external secrets
+- add workflows callback url to smol-k8s-lab provisioning process for argocd
diff --git a/demo/argo-workflows/argocd-application.yaml b/demo/argo-workflows/argocd-application.yaml
@@ -7,22 +7,10 @@ metadata:
   annotations:
     argocd.argoproj.io/sync-wave: "2"
 spec:
-  project: default
+  project: argo-cd
   destination:
     server: "https://kubernetes.default.svc"
     namespace: argocd
-  sources:
-    # official helm repo
-    - repoURL: 'https://argoproj.github.io/argo-helm/'
-      chart: argo-workflows
-      targetRevision: 0.45.2
-      helm:
-        valueFiles:
-        - $values/demo/argo-workflows/values.yaml
-    # our values.yaml file locally
-    - repoURL: 'https://github.com/small-hack/argocd-apps.git'
-      targetRevision: main
-      ref: values
   syncPolicy:
     syncOptions:
       - ApplyOutOfSyncOnly=true
@@ -94,7 +82,7 @@ spec:
           namespace:
           serviceAccount:
             # -- Specifies whether a service account should be created
-            create: false
+            create: true
             # -- Labels applied to created service account
             labels: {}
             # -- Annotations applied to created service account
@@ -285,7 +273,7 @@ spec:
           # workflows. This controls where the service account and RBAC resources will
           # be created. Only valid when singleNamespace is false.
           workflowNamespaces:
-            - default
+            - argocd
 
           instanceID:
             # -- Configures the controller to filter workflow submissions
@@ -733,7 +721,7 @@ spec:
             redirectUrl: "https://workflows.buildstar.online/oauth2/callback"
             rbac:
               # -- Adds ServiceAccount Policy to server (Cluster)Role.
-              enabled: true
+              enabled: false
             # -- Whitelist to allow server to fetch Secrets
             ## When present, restricts secrets the server can read to a given list.
             ## You can use it to restrict the server to only be able to access the
@@ -746,7 +734,7 @@ spec:
               - openid
               - profile
               - email
-              # - groups
+              - groups
             # -- Define how long your login is valid for (in hours)
             ## If omitted, defaults to 10h.
             sessionExpiry: ""