Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for zero job count in seek.rb returning "No jobs found" #2800

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add check for zero job count in seek.rb returning "No jobs found" #2800

wants to merge 8 commits into from

Conversation

Suvendu-UI
Copy link

changed the lines in seek.rb

@github-actions github-actions bot added the seek label Oct 9, 2024
@BaseMax
Copy link
Member

BaseMax commented Oct 9, 2024

Thank you for your contribute.

@BaseMax
Copy link
Member

BaseMax commented Oct 9, 2024

John will check it within next 5-6h.

@jbampton jbampton self-assigned this Oct 13, 2024
@jbampton
Copy link
Member

I think this check should be at the bottom of the Ruby script ?

@jbampton jbampton marked this pull request as draft October 13, 2024 14:06
@jbampton jbampton linked an issue Oct 13, 2024 that may be closed by this pull request
seek: if there are no jobs found when searching print "No jobs found" #2798
Open
@Suvendu-UI Suvendu-UI marked this pull request as ready for review October 14, 2024 15:20
@BaseMax
Copy link
Member

BaseMax commented Oct 16, 2024

?

1 similar comment
@BaseMax
Copy link
Member

BaseMax commented Oct 19, 2024

?

defihook
defihook reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@defihook defihook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

@BaseMax
Copy link
Member

BaseMax commented Nov 26, 2024

update

@BaseMax
Copy link
Member

BaseMax commented Dec 16, 2024

update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defihook defihook defihook left review comments

@anufdo anufdo Awaiting requested review from anufdo anufdo is a code owner

@ayushrana182 ayushrana182 Awaiting requested review from ayushrana182 ayushrana182 is a code owner

@BaseMax BaseMax Awaiting requested review from BaseMax BaseMax is a code owner

@jbampton jbampton Awaiting requested review from jbampton jbampton is a code owner

@smriad smriad Awaiting requested review from smriad smriad is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@jbampton jbampton

Labels
good first issue 🥇 Good for newcomers hacktoberfest ruby 💎 seek size/XS web scraping 🔪
Projects
slurp
Status: Review in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seek: if there are no jobs found when searching print "No jobs found"
4 participants
@Suvendu-UI @BaseMax @jbampton @defihook