Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename Exception to ExceptionCode #281

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

CosminPerRam
Copy link
Contributor

In #279 @uklotzde mentioned that:

I have noticed that the naming of the types FunctionCode and Exception is inconsistent. Shouldn't Exception better be renamed to ExceptionCode to reflect this duality?

This PR does exactly this, renames Exception to ExceptionCode.

Also, should associated types be renamed? This is an example:

type Exception = Exception;

To become:

type ExceptionCode = ExceptionCode

@uklotzde
Copy link
Member

Also, should associated types be renamed? This is an example:

type Exception = Exception;

To become:

type ExceptionCode = ExceptionCode

I don't think so. The type name Exception is appropriate here. It could be any type that could be converted into an ExceptionCode.

@uklotzde uklotzde added this to the v0.15.0 milestone Sep 12, 2024
@uklotzde uklotzde merged commit 7d5fadc into slowtec:main Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants