-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Report Server ID
(function code 17)
#274
Conversation
Welcome and thank you for contributing! If you have ideas on how to improve the situation around |
Please ignore the pre-commit failure. I'll take care of that separately. After merging #275 this should be fixed. |
Merging |
6ac44f5
to
1bbc4de
Compare
Rebased on As of support for custom functions, I think that a trait-based solution might be useful, though that will be a massive overhaul of the crate. Nonetheless, I will try to describe this idea in #123 so it can get some feedback before being implemented (by me or by someone else). |
In most cases you don't need to rebase. This would invalidate previous review comment. Each PR will be squashed into a single commit when merged. |
Both the public API and the internal implementation could be improved and optimized in many ways. |
Technically this is a breaking change because Opinions? |
The breaking change only affects the (experimental) server-side API. Another reason why this should not be bundled in a single crate together with the client-side API. |
This MR implements the
Report Server ID
function (code 17) from the spec.I tried to work around the absence of this function using
Custom
requests and responses, but it turns outtokio-modbus
does not support them properly. Since this function is defined in the spec, I decided to add native support for this function.