Skip to content

Commit

Permalink
Fix prop collision on heroes
Browse files Browse the repository at this point in the history
  • Loading branch information
slmnio committed Nov 22, 2024
1 parent b37247a commit 9a75059
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion website/src/components/broadcast/roots/GFXRoot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
v-bind="overlayProps"
:player="gfx.players?.[0]"
:team="gfx.teams?.[0]"
:hero="gfx.heroes?.[0]" />
:custom-hero="gfx.heroes?.[0]" />
<StatsGFXOverlay v-if="gfx?.type?.startsWith('Stats: ')" v-bind="overlayProps" />
<v-style>
{{ gfx?.custom_css }}
Expand Down
4 changes: 2 additions & 2 deletions website/src/components/broadcast/roots/MVPOverlay.vue
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ import { cleanID } from "@/utils/content-utils.js";
export default {
name: "MVPOverlay",
components: { ThemeTransition, ThemeLogo, RecoloredHero },
props: ["broadcast", "title", "animationActive", "showSponsor", "player", "team", "hero"],
props: ["broadcast", "title", "animationActive", "showSponsor", "player", "team", "customHero"],
computed: {
match() {
return ReactiveRoot(this.broadcast?.live_match?.[0], {
Expand Down Expand Up @@ -121,7 +121,7 @@ export default {
return (this.mvp.member_of || []).find(team => (this.match?.teams || []).some(t => t.id === team.id));
},
hero() {
return this.hero || this.broadcast?.highlight_hero || this.mvp?.favourite_hero;
return this.customHero || this.broadcast?.highlight_hero || this.mvp?.favourite_hero;
},
borderColor() {
return {
Expand Down

0 comments on commit 9a75059

Please sign in to comment.