Day/20170406 #7
Open
Day/20170406 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongjunjung
added a commit
to yongjunjung/web-application-server
that referenced
this pull request
Apr 13, 2017
javajigi
reviewed
Apr 14, 2017
|
|
||
| public HttpRequest(InputStream in) throws Exception { | ||
| BufferedReader br = new BufferedReader(new InputStreamReader(in, "UTF-8")); | ||
| getRequestLine(br); |
There was a problem hiding this comment.
오호. 리팩토링 잘 하셨네요. 고민의 흔적이 느껴집니다.
어제 라이브 코딩에서 했듯이 이 각각의 method를 새로운 객체로 분리하는 시도를 해보시면 또 다른 재미를 느끼실 겁니다.
javajigi
reviewed
Apr 14, 2017
| @@ -44,6 +114,38 @@ private void response200Header(DataOutputStream dos, int lengthOfBodyContent) { | |||
| } | |||
| } | |||
|
|
|||
| private void response302Header(DataOutputStream dos, String redirectUrl) { | |||
There was a problem hiding this comment.
응답 처리하는 부분에 많은 중복 코드가 있는데요.
이 부분을 HttpResponse를 만들어 제거하는 방법을 고민해 보면 좋겠어요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.