🐛 fix(s3): correct order of ifs, fixed parsing edgecases

sladg · Dec 12, 2023 · ddcf30b · ddcf30b
1 parent c620bba
commit ddcf30b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/imaginex_lambda/lib/img_lib.py b/imaginex_lambda/lib/img_lib.py
@@ -178,11 +178,12 @@ def download_and_optimize(url: str,
         raise HandlerError('height must be greater than zero')
 
     with TemporaryFile() as buffer:
-        if is_absolute(url):
-            buffer, _ = download_image(buffer, url, chunk_size)
         if is_s3(url):
-            bucket_name, key = unquote(url).replace('s3://', '').split('/', 1)
-            buffer, _ = get_s3_image(buffer, bucket_name, key, chunk_size)
+            dynamic_bucket, key = unquote(url).replace('s3://', '').split('/', 1)
+            logger.info("Dynamic bucket: %s", dynamic_bucket)
+            buffer, _ = get_s3_image(buffer, dynamic_bucket, key, chunk_size)
+        elif is_absolute(url):
+            buffer, _ = download_image(buffer, url, chunk_size)
         else:
             key = url.strip('/')
             buffer, _ = get_s3_image(buffer, bucket_name, key, chunk_size)