Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace eslint with biome for formatting and linting #58

Merged
merged 3 commits into from
Dec 3, 2024
Merged

chore: replace eslint with biome for formatting and linting #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d6749b
build: replace eslint with biome
zimeg Dec 2, 2024
ca248a1
fix: ignore the codecov api files from formatting
zimeg Dec 2, 2024
ead05e0
chore: run the linter and write formatting fixes too
zimeg Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
View file
Open in desktop

This file was deleted.

144 changes: 0 additions & 144 deletions .eslintrc.js
View file
Open in desktop

This file was deleted.

30 changes: 30 additions & 0 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
"files": {
"ignore": [".api", "*.json"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.api here ignores the vendored codecov packaging which seems to use a compiled module?

The fixes required for the linter were not immediate or obvious, but I don't expect changes to happen to these files often so I think we're safe to ignore it here!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so too! By the way, where can the file be placed? If it's under a codecov-specific directory, we may want to skip the whole directory to avoid being bothered by similar files in the future. If it can be placed everywhere, this config should be good to go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like .api stores generated files in ce66298 from codecov OpenAPI responses 📚

AFAIK this .api directory could be called something else, but we would just have to update the package path:

slack-health-score/package.json

Line 37 in b8d5739

"@api/codecov": "file:.api/apis/codecov"

I'll keep this in mind with future updates, but think this'll be ok to merge as is!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, it's not "*.api"... I was assuming that it's file extension 🤦 Thanks for sharing the details!

"ignoreUnknown": true
},
"formatter": {
"enabled": true,
"indentStyle": "space"
},
"javascript": {
"formatter": {
"quoteStyle": "single"
}
},
"linter": {
"enabled": true,
"rules": {
"recommended": true
}
},
"organizeImports": {
"enabled": true
},
"vcs": {
"enabled": true,
"clientKind": "git",
"useIgnoreFile": true
}
}
Loading
Loading