Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update README #9

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat: update README #9

merged 3 commits into from
Jan 11, 2024

Conversation

misscoded
Copy link
Contributor

@misscoded misscoded commented Jan 11, 2024

Summary

Updates README to reflect how this library is intended to be used. Resolves #6.

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_and_run_tests.sh after making the changes.

@misscoded misscoded added the documentation Improvements or additions to documentation label Jan 11, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@misscoded misscoded requested a review from zimeg January 11, 2024 00:11
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Left a few comments, some just thoughts, but think we might want to include a note on how to install these hooks to a project before merging.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@WilliamBergamin WilliamBergamin changed the title Update README feat: update README Jan 11, 2024
Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the comments once resolved this looks good to me 💯

This will resolve #6

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the comments from others cover all the important tweaks as far as I can tell.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@misscoded misscoded merged commit a85d12e into main Jan 11, 2024
11 checks passed
@WilliamBergamin WilliamBergamin deleted the update-readme branch January 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve README
5 participants