Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:add a linter --write precommit hook #2037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaodada123
Copy link

Summary

finish the issue #2034, add a linter --write precommit hook
The main changes are the addition of a package.json file to the root directory and the addition of a.husky directory to the.gitignore file

Requirements (place an x in each [ ])

Copy link

Thanks for the contribution! Before we can merge this, we need @yaodada123 to sign the Salesforce Inc. Contributor License Agreement.

@filmaj
Copy link
Contributor

filmaj commented Sep 23, 2024

Thanks for trying to fix the issue! However, a few things:

  • How does this work? How would I, as a maintainer, use this? Such information should be added to the .github/maintainers_guide.md
  • I would like to avoid adding a package.json to the root of this repo if possible, as I believe it complicates the maintainer approach. Now maintainers need to ensure they have two sets of dependencies up to date, yes? The root one, as well as individual sub-packages within this monorepo?
  • We cannot accept this contribution with the CLA being signed.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (02f9b87) to head (996b936).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2037   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files          37       37           
  Lines        9981     9981           
  Branches      633      631    -2     
=======================================
  Hits         9234     9234           
  Misses        747      747           
Flag Coverage Δ
cli-hooks 95.23% <ø> (ø)
cli-test 96.00% <ø> (ø)
oauth 81.52% <ø> (ø)
socket-mode 59.08% <ø> (ø)
web-api 97.29% <ø> (ø)
webhook 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants