Add support for wildcard/unscoped channel/workspace event trigger definitions #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
added
enhancement
filmaj
added
semver:minor
filmaj
commented
Apr 15, 2024
| /** @description The channel id's that this event listens on */ | ||
| channel_ids: PopulatedArray<string>; | ||
| // deno-lint-ignore no-explicit-any | ||
| [otherOptions: string]: any; |
There was a problem hiding this comment.
This was moved down to BaseEvent
filmaj
commented
Apr 15, 2024
| & BaseEvent | ||
| & { | ||
| /** @description The type of event */ | ||
| event_type: Extract<ChannelTypes, MessageMetadataTypes>; |
There was a problem hiding this comment.
Removed this line by extending from ChannelEvent instead of BaseEvent
filmaj
commented
Apr 15, 2024
| [otherOptions: string]: any; | ||
| }; | ||
|
|
||
| type BaseWorkspaceEvent = BaseEvent & { |
There was a problem hiding this comment.
Merged BaseWorkspaceEvent into WorkspaceEvents, since they are only used here.
filmaj
commented
Apr 15, 2024
| name: "test", | ||
| workflow: "#/workflows/example", | ||
| inputs: {}, | ||
| // @ts-expect-error requires one of `all_resources:true` or `channel_ids` |
There was a problem hiding this comment.
Using @ts-expect-error, we can test for the error path, which I think is very helpful for maintaining types. If we have a large enough set of these type tests, we will be able to more easily refactor the types with less worry about forgetting something.
WilliamBergamin
approved these changes
Apr 15, 2024
| }; | ||
| } | ||
| // deno-lint-ignore no-explicit-any | ||
| & Record<string, any>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes slackapi/deno-slack-sdk#222 and slackapi/deno-slack-sdk#298
Allows for use of
all_resources: booleanin a channel event trigger'seventobject. Previously, channel event types required a hard-coded list ofchannel_ids(so were scoped to specific channels by default).