Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team.externalTeams.disconnect and conversations.externalInvitePermissions.set APIs #106

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Jul 2, 2024

No description provided.

@filmaj filmaj added enhancement New feature or request semver:minor requires a minor version number bump labels Jul 2, 2024
@filmaj filmaj self-assigned this Jul 2, 2024
@filmaj filmaj requested a review from a team as a code owner July 2, 2024 21:24
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc8772a) to head (4fb23a1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1091      1091           
  Branches        16        16           
=========================================
  Hits          1091      1091           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these quick additions 🙏

@@ -10,6 +10,7 @@ export type TeamAPIType = {
info: SlackAPIMethod;
};
externalTeams: {
disconnect: SlackAPIMethod;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see this keeping order 🍤

@filmaj filmaj merged commit 26fcdd6 into main Jul 2, 2024
13 checks passed
@filmaj filmaj deleted the apis-team-disc-set-prof branch July 2, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver:minor requires a minor version number bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants