Skip to content

Commit

Permalink
update golangci-lint version in github actions workflow ; print golan…
Browse files Browse the repository at this point in the history
…gci-lint version on make lint
  • Loading branch information
0pcom committed Oct 19, 2024
1 parent 029b603 commit 0f72ea8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Install Requirements
run: |
GO111MODULES=off; go mod vendor
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.3
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.61.0
- name: Setup SSH Key Build and run e2e
run : |
make e2e-build
Expand Down
7 changes: 4 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ clean: ## Clean compiled binaries
## : ## _ [Test and lint]

install-linters: ## Install linters
- VERSION=1.40.0 ./ci_scripts/install-golangci-lint.sh
- VERSION=1.61.0 ./ci_scripts/install-golangci-lint.sh
GOPRIVATE=github.com/skycoin/* go get -u github.com/FiloSottile/vendorcheck
# For some reason this install method is not recommended, see https://github.com/golangci/golangci-lint#install
# However, they suggest `curl ... | bash` which we should not do
Expand All @@ -89,8 +89,9 @@ install-shellcheck: ## install shellcheck to current directory
./ci_scripts/install-shellcheck.sh

lint: ## Run linters. Use make install-linters first.
golangci-lint run -c .golangci.yml ./...
go vet -all -mod=vendor ./...
golangci-lint version
${OPTS} golangci-lint run -c .golangci.yml ./...
${OPTS} go vet -all -mod=vendor ./...

lint-windows-appveyor: ## Run linters. Use make install-linters first.
C:\Users\appveyor\go\bin\golangci-lint run -c .golangci.yml ./...
Expand Down

0 comments on commit 0f72ea8

Please sign in to comment.