-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Improving docs, examples, and tutorials of pytorch-forecasting #1745
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question, since this is not a draft - is this complete or still in progress? The changes currently are only a new table of contents, which is nice but not the entire scope of the issue.
It's still in progress at the moment! Do drafts also trigger the read the docs build? I'm primarily keeping it in this state so that I can see how it looks like after changes |
yes, CI is triggered both by "ready" and "draft" PR. The "draft" state is mainly cosmetic and for signposting that it is not ready. |
Thanks! If you have anymore suggestions, feel free to post it here in or in the issue thread :). I'm not sure if we are planning to refactor the |
Yes, we probably will, see here: #1736 What did you have in mind for the examples? |
relates to #1718
Implements the proposed changes in above issue.