Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve i2c error logging #552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve i2c error logging #552

wants to merge 3 commits into from

Conversation

mutatrum
Copy link
Contributor

@mutatrum mutatrum commented Dec 4, 2024

Fixes #551

Example:

E (7057) i2c.master: I2C transaction unexpected nack detected
E (7067) i2c.master: s_i2c_synchronous_transaction(917): I2C transaction failed
E (7067) i2c.master: i2c_master_multi_buffer_transmit(1166): I2C transaction failed
E (7077) i2c_bitaxe: Device SSD1306 (0x3c)

Bit of a convoluted solution because i2c_master_dev_handle_t is not accessible. Maybe there's a better solution possible?

@WantClue WantClue requested a review from skot December 4, 2024 22:36
WantClue
WantClue approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WantClue WantClue added the enhancement New feature or request label Dec 4, 2024
@WantClue
Copy link
Collaborator

please resolve the conflicts

@mutatrum
Copy link
Contributor Author

Conflicts resolved

@mutatrum
Copy link
Contributor Author

mutatrum commented Dec 12, 2024 •
edited
Loading

Fixes #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WantClue WantClue WantClue approved these changes

@skot skot Awaiting requested review from skot

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Add component tagging to i2c errors
2 participants
@mutatrum @WantClue