Reduce invalid job found log from error to warning #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eandersson
changed the title
|
a rejected share seems slightly more important than INFO... maybe WARN? |
Yea - maybe warning. Most important is that we are consistent across all chip types. Mostly worried about these being misread as a serious issue (red-herring) when it is much more likely to be the symptom and not the cause, most of the time it is due to a mining.notify or connectivity instability. |
skot
requested changes
Nov 30, 2024
Updated |
WantClue
approved these changes
Dec 2, 2024
WantClue
added
enhancement
eandersson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this message can be useful, most commonly it is seen after receiving a mining.notify, or briefly getting disconnected from the pool. changing it from a ERROR to WARNING log message to not scare users.
This also makes the implementation more consistent, as in some places and chips we already logged as ERROR and in other places as INFO.