TCH - 2.1.9 All-In-One PR #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fan without restart
WantClue
reviewed
Aug 8, 2024
mutatrum
reviewed
Aug 15, 2024
| void EMC2302_set_fan_speed(uint8_t devicenum, float percent) | ||
| { | ||
| uint8_t speed; | ||
| uint8_t FAN_SETTING_REG = EMC2302_FAN1_SETTING + (devicenum * 0x10); |
There was a problem hiding this comment.
Don't do arithmetic with constants, this is bound to cause problems. Use ifs or switch and handle out of bound devicenum.
improved hashrate, calculation is now more stable and hashrate will be calculated over an average of 10minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1.9 base for universail build for ultra, supra and hex. with some UI fix and fan control improvement. Bug fix for EMC2302 for fan speed setting.