-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis Fix, Github Actions, heroku fix #432
Conversation
- Fix travis-ci - Add github actions ci - Remove 2.7, 3.5 from ci - Add 3.6, 3.7, 3.8, 3.9 to ci - Various requirements changes to support current python & fix tests - Fix flake8 errors - Bumped Heroku to python-3.9.2. I tested heroku with 3.6, 3.7, 3.8, 3.9 all with the new slack_update and it worked. Travis is migrating away from travis-ci.org to travis-ci.com and changing how the free tier works. I would support moving away from travis and embracing github actions. But it doesn't hurt anything to run both for now.
Oh this is fantastic, thank you for putting this together! I'll take a closer look but I'm assuming we don't have any breaking changes to deal with after updating dependencies? |
I don’t know of any breaking changes. The current tests we have all pass, and it boots on heroku. The web interface loads, and the bot responds to ping on slack. I don’t have rocket chat to test. |
CherryPy is pinned to the version just before 9 because bottle hasn’t kept pace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things I spotted
The Docker builds are probably broken. I can work on that if nobody else is assigned. I would have included those fixes but I wanted to keep the scope within reason. |
I took a peak and the py3 container builds, I'm not sure about access to the will docker repo. @skoczen if you can add me (username Ashex) to the will docker repos that would be great so we can push new releases to it. |
They may be triggered by commit |
That was my thought but the images haven't been updated in 3 years: |
1bea65d
to
4755e1e
Compare
- exclude flake8 for natural
I made a mess of the commits, but I think I have it mostly cleaned up now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, everything looks great to me so I'll approve. I'll squash the commits and use the summary you provided for the log.
* Travis Fix, Github Actions, heroku fix - Fix travis-ci - Add github actions ci - Remove 2.7, 3.5 from ci - Add 3.6, 3.7, 3.8, 3.9 to ci - Various requirements changes to support current python & fix tests - Fix flake8 errors - Bumped Heroku to python-3.9.2. I tested heroku with 3.6, 3.7, 3.8, 3.9 all with the new slack_update and it worked. Travis is migrating away from travis-ci.org to travis-ci.com and changing how the free tier works. I would support moving away from travis and embracing github actions. But it doesn't hurt anything to run both for now. * Removed duplicate comment * Removed redundant pip installs * - Pin natural to github version - exclude flake8 for natural * Pin natural to github commit
Travis is migrating away from travis-ci.org to travis-ci.com and changing how the free tier works. I would support moving away from travis and embracing github actions. But it doesn't hurt anything to run both for now.