Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox support for py3, flake8 cleanup #401

Merged
merged 12 commits into from
Jan 31, 2019

Conversation

chillipeper
Copy link
Collaborator

  • Add py35, py36, py37 envlist in tox.ini

  • Fix flake8 errors

./will/utils.py:102:9:` E117 over-indented
./will/main.py:39:5: F821 undefined name 'reload'
./will/main.py:565:17: E117 over-indented
./will/backends/io_adapters/hipchat.py:288:25: E117 over-indented
  • Bump version of PyYAML to 3.13 and requests to 2.20.0 to support py37.
  • Make tests pass in travis

Result:

_________________________________________________________________________________________________ summary __________________________________________________________________________________________________
  py27: commands succeeded
  py35: commands succeeded
  py36: commands succeeded
  py37: commands succeeded
  flake8: commands succeeded
  congratulations :)

@chillipeper
Copy link
Collaborator Author

Added support for python3.4. This should resolve #366 issue and PR #367 should not be longer needed.

@wontonst could you please take a look when you have a chance?

@wontonst
Copy link
Collaborator

Looks good to me. Have you checked that the minor version upgrades to req.txt do not break anything?

@chillipeper
Copy link
Collaborator Author

I have been using those upgrades with python 3.7 in prod for the last month, nothing obvious has broken.

@rsalmond
Copy link
Collaborator

I've also been using an updated copy of requests in prod for a while without issues.

@wontonst wontonst merged commit 2d96303 into skoczen:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants