Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sending SMS #342

Open
wants to merge 199 commits into
base: master
Choose a base branch
from
Open

Support for sending SMS #342

wants to merge 199 commits into from

Conversation

dsrowell
Copy link

This code allows Twilio users to send SMS messages from Will.

I am not affiliated with Twilio, other than being a satisfied customer.

woohgit and others added 30 commits October 8, 2017 12:46
The old world weather API is no more. The replacement does not provide the local time in the JSON output.
The solution is migrating the plugin to use the google apis which provides the timeZoneId, which is definitely enough for the `pytz` to generate a datetime object.
In the console the HTML tags look pretty uggly and it's better to eliminate them completely.
…_backend

strip HTML tags for shell backend
* Tenzer-all-the-changes:
  Add Jeppe Toustrup to the AUTHORS list
  Bugfix: Avoid the use of `locals()` in the reminder plugin
  Bugfix: Don't report HC/BB state if the previous state wasn't known
  Pylint: W0612, W0613, remove unused variables
  Pylint: C1801, don't use `len(i) == 0` as a condition in if statements
  Pylint: W1201, let the logging functions do string interpolation
  Bugfix: Correct regex for will.plugins.friendly.mornin plugin
  Cleanup: Remove broken random_topic plugin
  Python 3: Run tests in Python 3 along with Python 2
  Python 3: Use new way of representing octal numbers
  Python 3: Fix detection of plugin methods
  Python 3: Use new form of `except` lines
  Python 3: Make imports absolute and clean up unused ones
  Python 3: Use six to handle imports which have changed between 2 and 3
  Python 3: Update dependencies on dnspython and natural to get PY3 support
  Python 3: print is a function, not a statement
* feature/merges-in-py3:
  Friendlier location output
@skoczen
Copy link
Owner

skoczen commented Mar 19, 2018

@dsrowell wow, thanks so much for this, and welcome to the community! Twilio support was on my to-do list - I'm so happy to have it submitted to Will!

In terms of implementation, I'd much rather see this as an IOBackend, so it can have the full support of any Will plugins/code without people having to change to send_sms calls instead of reply/say.

What's your level of interest in moving this PR in that direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants