Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music added #553

Closed
wants to merge 1 commit into from
Closed

Music added #553

wants to merge 1 commit into from

Conversation

arunimaChintu
Copy link

@arunimaChintu arunimaChintu commented Aug 1, 2024

Description

This adds music
Fixes: #552

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Copy link

github-actions bot commented Aug 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@arunimaChintu
Copy link
Author

@aditya-bhaumik Please merge this and please assign the levels and labels

@aditya-bhaumik
Copy link
Collaborator

@arunimaChintu please share a recording of what exactly this change does

i runned it in my local machine there is no change in the website

@aditya-bhaumik aditya-bhaumik requested a review from sk66641 August 1, 2024 17:47
@aditya-bhaumik aditya-bhaumik added gssoc This Contribution is under GSSOC'24 level1 labels Aug 1, 2024
@arunimaChintu
Copy link
Author

@aditya-bhaumik it adds music in it, the rest is same... I cant screen record with music in my system... but it works I have tested it...

@aditya-bhaumik
Copy link
Collaborator

@arunimaChintu isnt there already a feature for changing the background music i downloaded your code and tested it in my local machine

Please provide a recording so that i can understand what new change is made

@aditya-bhaumik
Copy link
Collaborator

@sk66641 please review this pull request as i tested in local machine but cant find any change

@sk66641
Copy link
Owner

sk66641 commented Aug 1, 2024

@arunimaChintu
it seems you have simply added a music which autoplay on the loading of the page which is different from the issue #552 where you talked about music sync issue

@sk66641 sk66641 closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[Feature]: Add "Music sync"
3 participants