feat: allow 1 char first names for insurance subscriber (openemr#7715)

* feat: allow 1 char first names for insurance subscriber * change Tests Validators to use empty fname * update patient service test to use empty fname
sjpadgett · Sep 18, 2024 · 704bfd0 · 704bfd0
1 parent b759180
commit 704bfd0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/Billing/X125010837P.php b/src/Billing/X125010837P.php
@@ -663,7 +663,7 @@ public static function genX12837P(
         $proccount = $claim->procCount();
         $clm_total_charges = 0;
         for ($prockey = 0; $prockey < $proccount; ++$prockey) {
-            $clm_total_charges += $claim->cptCharges($prockey);
+            $clm_total_charges += floatval($claim->cptCharges($prockey));
         }
         if (!$clm_total_charges) {
             $log .= "*** This claim has no charges!\n";

diff --git a/src/Validators/CoverageValidator.php b/src/Validators/CoverageValidator.php
@@ -69,7 +69,7 @@ function (Validator $context) {
                 $context->optional('group_number')->lengthBetween(2, 255);
                 $context->required('subscriber_lname')->lengthBetween(2, 255);
                 $context->optional('subscriber_mname')->lengthBetween(1, 255);
-                $context->required('subscriber_fname')->lengthBetween(2, 255);
+                $context->required('subscriber_fname')->lengthBetween(1, 255);
                 $context->required('subscriber_relationship')->listOption('sub_relation')
                     ->callback(function ($value, $values) {
                         if (

diff --git a/src/Validators/PatientValidator.php b/src/Validators/PatientValidator.php
@@ -53,7 +53,7 @@ protected function configureValidator()
         $this->validator->context(
             self::DATABASE_INSERT_CONTEXT,
             function (Validator $context) {
-                $context->required("fname", "First Name")->lengthBetween(2, 255);
+                $context->required("fname", "First Name")->lengthBetween(1, 255);
                 $context->required("lname", 'Last Name')->lengthBetween(2, 255);
                 $context->required("sex", 'Gender')->lengthBetween(4, 30);
                 $context->required("DOB", 'Date of Birth')->datetime('Y-m-d');

diff --git a/tests/Tests/Services/PatientServiceTest.php b/tests/Tests/Services/PatientServiceTest.php
@@ -51,7 +51,7 @@ public function testGetFreshPid()
      */
     public function testInsertFailure()
     {
-        $this->patientFixture["fname"] = "A";
+        $this->patientFixture["fname"] = "";
         $this->patientFixture["DOB"] = "12/27/2017";
         unset($this->patientFixture["sex"]);
 
@@ -93,7 +93,7 @@ public function testUpdateFailure()
     {
         $this->patientService->insert($this->patientFixture);
 
-        $this->patientFixture["fname"] = "A";
+        $this->patientFixture["fname"] = "";
 
         $actualResult = $this->patientService->update("not-a-uuid", $this->patientFixture);
 

diff --git a/tests/Tests/Validators/PatientValidatorTest.php b/tests/Tests/Validators/PatientValidatorTest.php
@@ -69,7 +69,7 @@ public function testValidationInsertSuccess()
     public function testValidationUpdateFailure()
     {
         $this->patientFixture["uuid"] = $this->fixtureManager->getUnregisteredUuid();
-        $this->patientFixture["fname"] = "A";
+        $this->patientFixture["fname"] = "";
         $this->patientFixture["sex"] = "M";
 
         $actualResult = $this->patientValidator->validate($this->patientFixture, PatientValidator::DATABASE_UPDATE_CONTEXT);