Skip to content

Commit

Permalink
selftests/memfd: add test for mapping write-sealed memfd read-only
Browse files Browse the repository at this point in the history
Now we have reinstated the ability to map F_SEAL_WRITE mappings read-only,
assert that we are able to do this in a test to ensure that we do not
regress this again.

Link: https://lkml.kernel.org/r/a6377ec470b14c0539b4600cf8fa24bf2e4858ae.1732804776.git.lorenzo.stoakes@oracle.com
Signed-off-by: Lorenzo Stoakes <[email protected]>
Cc: Jann Horn <[email protected]>
Cc: Julian Orth <[email protected]>
Cc: Liam R. Howlett <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Vlastimil Babka <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
lorenzo-stoakes authored and akpm00 committed Dec 23, 2024
1 parent b0de076 commit 2d0a4f3
Showing 1 changed file with 43 additions and 0 deletions.
43 changes: 43 additions & 0 deletions tools/testing/selftests/memfd/memfd_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,24 @@ static void *mfd_assert_mmap_shared(int fd)
return p;
}

static void *mfd_assert_mmap_read_shared(int fd)
{
void *p;

p = mmap(NULL,
mfd_def_size,
PROT_READ,
MAP_SHARED,
fd,
0);
if (p == MAP_FAILED) {
printf("mmap() failed: %m\n");
abort();
}

return p;
}

static void *mfd_assert_mmap_private(int fd)
{
void *p;
Expand Down Expand Up @@ -980,6 +998,30 @@ static void test_seal_future_write(void)
close(fd);
}

static void test_seal_write_map_read_shared(void)
{
int fd;
void *p;

printf("%s SEAL-WRITE-MAP-READ\n", memfd_str);

fd = mfd_assert_new("kern_memfd_seal_write_map_read",
mfd_def_size,
MFD_CLOEXEC | MFD_ALLOW_SEALING);

mfd_assert_add_seals(fd, F_SEAL_WRITE);
mfd_assert_has_seals(fd, F_SEAL_WRITE);

p = mfd_assert_mmap_read_shared(fd);

mfd_assert_read(fd);
mfd_assert_read_shared(fd);
mfd_fail_write(fd);

munmap(p, mfd_def_size);
close(fd);
}

/*
* Test SEAL_SHRINK
* Test whether SEAL_SHRINK actually prevents shrinking
Expand Down Expand Up @@ -1593,6 +1635,7 @@ int main(int argc, char **argv)

test_seal_write();
test_seal_future_write();
test_seal_write_map_read_shared();
test_seal_shrink();
test_seal_grow();
test_seal_resize();
Expand Down

0 comments on commit 2d0a4f3

Please sign in to comment.