-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Stack Trace in Debug Pane #76
base: master
Are you sure you want to change the base?
Conversation
This sounds great, thank you very much for your efforts! I'll try and take a look in the next week and will keep you posted. |
I started working on extending this to include more inspection functionality. Should that be included in this pull request, or should it get a separate pull request? The code for stack traces is complete now, but the other functionalities needs a fair bit of work yet. |
I've gotten the additional functionality working nicely. So, all in total this adds:
This seems to cover all the functionality listed in Slime's documentation except for pretty-print-eval in-frame (I can't remember the complication that came up) and the stepping commands (mainly because I'm not figuring out a good way to implement them and they seem less useful than the rest of this). I've tested using SBCL 1.4.2 on Windows 10 and Atom 1.27.2 Here's what it ends up looking like: |
Awesome ! And congrats. |
Wow, great work! Thank you very much for your contributions! I apologize that I haven't had a chance to look at this yet, but it's definitely on my to-do list. I'll try to take a look soon :-) Thanks again! |
Hello, and up ? |
Features include * viewing local variables * viewing catch tags * restarting frames * returning specific values from frames * disassembling frames
Also, the layout of frame information was rearranged
I rebased this onto master and everything still appears to be working. |
This adds the stack trace to the debug pane, below the available restarts. It initially shows the stack frames that are sent with the initial debug message from swank, with an option to load the entire stack trace.
This pull request depends on sjlevine/swank-client-js#5.
This is my first time using Coffeescript, so please let me know if it can be improved. I used the code for restarts as my template.