escape square brackets in URI

workaround for https://bugs.ruby-lang.org/issues/12235
siteleaf · Sep 15, 2020 · 5b9739c · 5b9739c
1 parent 776bf9b
commit 5b9739c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/siteleaf/source_file.rb b/lib/siteleaf/source_file.rb
@@ -5,7 +5,9 @@ class SourceFile < Entity
     attr_reader :name, :url, :download_url, :type, :filesize, :sha, :created_at, :updated_at, :user_id
 
     def create_endpoint
-      ::File.join("sites", site_id, "source", URI.escape(identifier))
+      uri = URI.encode(identifier)
+      uri = uri.gsub('[', '%5B').gsub(']', '%5D') # workaround for https://bugs.ruby-lang.org/issues/12235
+      ::File.join('sites', site_id, 'source', uri)
     end
 
     def entity_endpoint
@@ -17,7 +19,7 @@ def identifier
     end
 
     def to_file
-      Client.get(::File.join("sites", site_id, "source", "#{URI.escape(identifier)}?download"))
+      Client.get("#{entity_endpoint}?download")
     end
 
   end

diff --git a/lib/siteleaf/version.rb b/lib/siteleaf/version.rb
@@ -1,3 +1,3 @@
 module Siteleaf
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end