-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Felix/track current trajectory #18
Conversation
trajectoryId, | ||
time.toISOString(), | ||
p.latLng[1].toFixed(8), | ||
p.latLng[0].toFixed(8), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coords are in reverse order right? points table is sorted lat first, lon second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I missed that mapbox is using the reversed way. I will resolve that
When I was trying to run the current development state on iOS I ran into this issue: @felixerdy Is that the sql problem you were referring to in one of the commit messages? |
I just tried it myself and your changes do seem to fix the problem. |
What's the idea behind adding a map view to the tracking page? Is this intended as a preview? Current UX is kinda weird, you enable tracking, go back and open an "example" trajectory, and select "Your Trajectory".. Then we have 2 options regarding the trajectory listing:
|
Meanwhile I'll cherrypick your iOS fix into develop, please rebase/merge |
I thought that was the idea behind issue #7
I agree that UX is currently weird. Also: do we need a separate page to start/stop recording? Maybe we could discuss that in a new issue and mark this PR as a draft (?) |
Reading this discussion I realized that the user trajectory is actually not showing up in the list of available trajectories on iOS. 🤔 |
Fixed on development branch: 256e9b4 |
We can delete this branch / pull request, right? |
Adding mapbox-gl to tracking page to see current trajectory. Using TrajectoryService and needs feature as described in #17.
Issue ref: #7
Note: Don't forget to set your mapbox access token in
src/environments/environment(.prod).ts