Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Felix/track current trajectory #18

Closed
wants to merge 4 commits into from

Conversation

felixerdy
Copy link
Collaborator

Adding mapbox-gl to tracking page to see current trajectory. Using TrajectoryService and needs feature as described in #17.

Issue ref: #7

Note: Don't forget to set your mapbox access token in src/environments/environment(.prod).ts

trajectoryId,
time.toISOString(),
p.latLng[1].toFixed(8),
p.latLng[0].toFixed(8),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coords are in reverse order right? points table is sorted lat first, lon second

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I missed that mapbox is using the reversed way. I will resolve that

@felixerdy felixerdy requested a review from noerw November 20, 2020 15:30
@zven
Copy link
Contributor

zven commented Nov 23, 2020

When I was trying to run the current development state on iOS I ran into this issue:
Screenshot 2020-11-22 at 14 31 35

@felixerdy Is that the sql problem you were referring to in one of the commit messages?

@zven
Copy link
Contributor

zven commented Nov 23, 2020

When I was trying to run the current development state on iOS I ran into this issue:
Screenshot 2020-11-22 at 14 31 35

@felixerdy Is that the sql problem you were referring to in one of the commit messages?

I just tried it myself and your changes do seem to fix the problem.

@noerw
Copy link
Member

noerw commented Nov 23, 2020

What's the idea behind adding a map view to the tracking page? Is this intended as a preview?
I mean, we already have the trajectory view with map & inferences etc at /trajectory/track/user.

Current UX is kinda weird, you enable tracking, go back and open an "example" trajectory, and select "Your Trajectory"..
Maybe add a button "analyze my trajectory" below the tracking-toggle on the tracking page. It links to /trajectory/track/user.

Then we have 2 options regarding the trajectory listing:

  1. "your trajectory" is not listed in the "view example trajectories" list anymore.
  2. "view example trajectories" button is renamed to something more generic, like "analyze trajectories"

@noerw
Copy link
Member

noerw commented Nov 23, 2020

Meanwhile I'll cherrypick your iOS fix into develop, please rebase/merge

@felixerdy
Copy link
Collaborator Author

What's the idea behind adding a map view to the tracking page? Is this intended as a preview?
I mean, we already have the trajectory view with map & inferences etc at /trajectory/track/user.

I thought that was the idea behind issue #7

Current UX is kinda weird, you enable tracking, go back and open an "example" trajectory, and select "Your Trajectory"..
Maybe add a button "analyze my trajectory" below the tracking-toggle on the tracking page. It links to /trajectory/track/user.

Then we have 2 options regarding the trajectory listing:

  1. "your trajectory" is not listed in the "view example trajectories" list anymore.
  2. "view example trajectories" button is renamed to something more generic, like "analyze trajectories"

I agree that UX is currently weird. Also: do we need a separate page to start/stop recording? Maybe we could discuss that in a new issue and mark this PR as a draft (?)

@zven
Copy link
Contributor

zven commented Nov 23, 2020

Reading this discussion I realized that the user trajectory is actually not showing up in the list of available trajectories on iOS. 🤔

@noerw noerw marked this pull request as draft November 23, 2020 15:24
@zven
Copy link
Contributor

zven commented Nov 23, 2020

Reading this discussion I realized that the user trajectory is actually not showing up in the list of available trajectories on iOS. 🤔

Fixed on development branch: 256e9b4

@zven
Copy link
Contributor

zven commented Dec 4, 2020

We can delete this branch / pull request, right?

@felixerdy felixerdy closed this Dec 8, 2020
@felixerdy felixerdy deleted the felix/track-current-trajectory branch December 8, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants