Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecosystem-vue documentation #608

Merged
merged 4 commits into from
May 3, 2024
Merged

Fix ecosystem-vue documentation #608

merged 4 commits into from
May 3, 2024

Conversation

hang-up
Copy link
Contributor

@hang-up hang-up commented Dec 5, 2023 •
edited
Loading

What's in this PR?

  • Clarified the documentation around custom props for Vue 2 vs Vue 3 apps
  • Updated dead references to /website/

@MilanKovacic
Copy link
Contributor

Can you please fix the conflicts?

@hang-up
Copy link
Contributor Author

hang-up commented Mar 28, 2024

Hi @MilanKovacic , apologies for the delay! The conflicts have been fixed.

@MilanKovacic MilanKovacic self-requested a review May 3, 2024 17:58
@MilanKovacic MilanKovacic merged commit bf01b5a into single-spa:master May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilanKovacic MilanKovacic MilanKovacic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hang-up @MilanKovacic