JP/single-spa-react #600
Closed
JP/single-spa-react #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are some screenshots of the changes. Apologies, I was test driving the GitHub PR extension in VS Code. It works nicely, but I could not add these shots in the original message.
|
|
I think we should fix latest single-spa-react to work with React 17, rather than update the documentation for it. See single-spa/single-spa-react#202 |
|
This documentation change is no longer necessary, due to the fix in [email protected] https://github.com/single-spa/single-spa-react/releases/tag/v6.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update example for React versions lower than v18.