fix parcel appendTo #199
Open
fix parcel appendTo #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0d2495 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
gm @MilanKovacic , can you help me adding the reviewers to this pr? thanks a lot! |
|
Hi, thank you for submitting the pull request. I will take a look. While waiting for the release, I recommend using https://www.npmjs.com/package/patch-package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pr fixes #157 by swapping the lines L50 with L51 in parcel.js
Minimal repro repository:
https://github.com/SeverS/single-spa-react-repro
gh-pages:
https://severs.github.io/single-spa-react-repro/
As you can see on gh-pages the button parcel works as expected when inline but when you click it it will throw an error in the console and the 'modal' parcel will never be mounted.